[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

LGTM

Please see #886 (comment)

Packagers need to add this to the .cargo/config so please add this to the release notes, cc @lsm5

[source."git+https://github.com/namib-project/nftables-rs.git?rev=1b0c60b"]
git = "https://github.com/namib-project/nftables-rs.git"
rev = "1b0c60b"
replace-with = "vendored-sources"

Please see #886 (comment)

Packagers need to add this to the .cargo/config so please add this to the release notes, cc @lsm5

[source."git+https://github.com/namib-project/nftables-rs.git?rev=1b0c60b"]
git = "https://github.com/namib-project/nftables-rs.git"
rev = "1b0c60b"
replace-with = "vendored-sources"

@baude mind adding this to rpm/netavark.spec in this PR? Or, I could do another PR and we can rebase this on top of that one. That way packit can pick up changes easily.

#894 needs to get in before the release PR can be merged for packit to pick up the change.

Needs a rebase

/lgtm
/hold

/hold cancel

This was not correctly rebased! The PR #894 is thus not part of the tag of the rpm builds are thus not working.

This was not correctly rebased! The PR #894 is thus not part of the tag of the rpm builds are thus not working.

No worries. I'll add the fix in to the Fedora spec file manually and rebuild.